CVE-2026-104129: pREST _groupby function-expression SQL injection (incomplete fix of CVE-2025-58450)

High CVSS 8.1

OSV id
GHSA-v9v2-98xq-627c
Also known as
CVE-2026-104129
Published
Last modified

Affected packages

PackageAffected versionsFixed in
github.com/prest/prest
Go
<= 1.5.5 after 1.5.5
github.com/prest/prest/v2
Go
< 2.4.0 2.4.0

How to fix it

github.com/prest/prest (Go)

No fix yet. No fixed version of github.com/prest/prest has been released yet.

  • Check the advisory and its references below for a workaround or a configuration change that turns off the affected feature.
  • Limit exposure: don't pass untrusted input to the affected code path, and keep it off public endpoints if you can.
  • Pin away from the affected versions if an older release is not affected, or consider replacing the package.
  • Watch for the fix: a free AIssue account checks your lockfiles every day and emails you when a fixed version is released.

github.com/prest/prest/v2 (Go)

Upgrade github.com/prest/prest/v2 to 2.4.0 or later.

go get github.com/prest/prest/v2@v2.4.0
go mod tidy
  • Indirect Go modules are upgraded the same way (`go get module@version`).
  • Check the changelog for breaking changes (especially across major versions), update the lockfile with the package manager, and run your tests.

Not sure whether your project uses an affected version? Check your lockfile below for free.

Details

What the fix did and the gap

The v2.3.0 fix (commit e88dabb) routed the _select field through a strict new gate, sanitizeSelectField (postgres.go:947/1003/2097). The sibling groupby path was left on the far weaker isSafeSQLExpression. adapters/postgres/postgres.go, GroupByClause (line 1946): a groupby field that contains balanced parens takes the raw-SQL-expression branch (around lines 1999-2006), gated only by isSafeSQLExpression (line 2001, defined at 2043). That gate validates only the OUTERMOST function name against a 13-entry allowlist and uses a character allowlist that permits spaces, single quotes and parens. It blocks ;, --, /* , unbalanced parens and an outer pg prefix, but NOT a trailing UNION SELECT ..., a nested (SELECT ...) subquery, or an inner pg function. sanitizeSelectField (the CVE fix) rejects exactly those.

Input and attacker

GET /{database}/{schema}/{table}?_select=id&groupby=upper((SELECT+1))+UNION+SELECT+currentuser. Sink trace: controllers/crud.go:131 calls GroupByClause unconditionally, concatenates it into sqlSelect (crud.go:133), executed at crud.go:176 with only the WHERE values parameterized. Reached after only a table read-permission check, passable unauthenticated in the default config (the same pipeline and attacker model as the anchor).

Verification level

EXECUTED with negative controls (agent-run go test ./adapters/postgres/, PASS): isSafeSQLExpression wrongly accepts four payloads and GroupByClause emits them raw (e.g. GROUP BY upper((SELECT 1)) UNION SELECT currentuser, and GROUP BY abs((SELECT 1 FROM pgsleep(3)))); negative controls with ; and -- are rejected; and sanitizeSelectField (the CVE fix) rejects the exact UNION payload the sibling gate accepts. I independently re-confirmed at HEAD that _groupby is gated by isSafeSQLExpression (postgres.go:2001) while select uses sanitizeSelectField (postgres.go:947). NOT verified: end-to-end UNION exfiltration against a live Postgres (needs column/type alignment, Postgres-gated). The pgsleep DoS primitive is unconditional and needs no alignment; char-by-char blind extraction is constrained (commas are pre-split, and =/</> are blocked).

Suggested fix

Route _groupby through the same strict gate as select (sanitizeSelectField-style: reject nested subqueries, UNION, inner pg functions, and anything past a single allowlisted function call), or parameterize/whitelist the group-by columns.

Also checked and SOUND

The other builders (WhereByRequest, OrderByRequest, JoinByRequest, CountByRequest, the jsonb/tsquery paths, ->>having, ident.IsValid) are sound; only the _groupby non-having function branch is the weak sibling.

Advisory-source note

Five-source enumeration: CVE-2025-58450 (GHSA-p46v-f2x8-qp98, "Systemic SQL Injection", GO-2025-3941) and the newer GHSA-qvx3-q8vx-9q3c (which covers _select, fixed v2.3.0). Neither mentions _groupby / GROUP BY. The systemic advisory's own "nested queries can be performed" note supports the incomplete-fix framing. Not contested.

Dedup

Dedup gate clean: no prest/prest blocking verdict in COVERED-INDEX, DISCLOSURE-INDEX or SCOUT-EXCLUDE.

Tooling

AI assistance wsa used while investigating. The injection is executed-verified with negative controls (isSafeSQLExpression accepts four UNION/subquery/pg_sleep payloads that GroupByClause emits raw, while ;/-- are rejected and the _select gate rejects the same UNION payload), and I confirmed at HEAD that _groupby uses the weak isSafeSQLExpression while _select was hardened with sanitizeSelectField.

References

Am I affected?

Upload or paste your lockfile. We check every package version in it against OSV.dev, this advisory included, and email you the vulnerable ones with the version that fixes them. Free, and no account needed.

or paste its content

Needed when you paste. package.json and pyproject.toml only have version ranges: use the lockfile next to them.

Only package names and versions are checked; the file itself is not kept. We use your email to send this report and nothing else unless you tick the box above. Privacy policy.

About this data

Source: GitHub Advisory Database via OSV.dev (CC-BY 4.0). Severity comes from the advisory's own rating when it has one, else from its CVSS score.